fix: 素材余量四字段兼容 Asset 领域实体(真实接口恒为 None 修复) #1550

Merged
auto-approve-bot merged 2 commits from fix/asset-availability-entity-meta into develop 2026-08-30 08:21:01 +08:00
Owner

背景

#1549 合并后 staging 真实接口验收发现:GET /assets 与 smart-match 返回的余量四字段恒为 None(usable 恒为 True 兜底)。

根因

路由层 repository 返回的是 Asset 领域实体(packages/domain/entities.py),不是 ORM AssetModel:

  • 实体的区间记录在 metadata dict 属性里(repository 与 classification_result JSON 列互转,见 asset_repository.py:133/162);
  • 实体没有 classification_result 属性;
  • _read_meta 只读 classification_result 列 → AttributeError → _asset_availability_fields 异常兜底 → 四字段 None + usable=True。

单测用 SimpleNamespace 同时带了两个属性,未暴露此问题。

修复

_read_meta 双形态兼容:

  • 对象有 metadata 且为 dict(领域实体)→ 直接使用;
  • 否则读 classification_result JSON 字符串(ORM AssetModel 形态,tracker 内部 DB 写入路径不变)。

测试

  • 新增实体形态用例(metadata dict、无 classification_result)与 ORM 形态用例对比;
  • 相关 5 个测试文件 64 passed;全量 unit 13913 passed。

staging 验收(容器内直调路由函数,真实 DB)

修复前:所有素材计算抛 AttributeError、四字段 None;
修复后待本 PR 部署复验。

## 背景 #1549 合并后 staging 真实接口验收发现:GET /assets 与 smart-match 返回的余量四字段恒为 None(usable 恒为 True 兜底)。 ## 根因 路由层 repository 返回的是 **Asset 领域实体**(packages/domain/entities.py),不是 ORM AssetModel: - 实体的区间记录在 `metadata` **dict** 属性里(repository 与 `classification_result` JSON 列互转,见 asset_repository.py:133/162); - 实体没有 `classification_result` 属性; - `_read_meta` 只读 `classification_result` 列 → AttributeError → `_asset_availability_fields` 异常兜底 → 四字段 None + usable=True。 单测用 SimpleNamespace 同时带了两个属性,未暴露此问题。 ## 修复 `_read_meta` 双形态兼容: - 对象有 `metadata` 且为 dict(领域实体)→ 直接使用; - 否则读 `classification_result` JSON 字符串(ORM AssetModel 形态,tracker 内部 DB 写入路径不变)。 ## 测试 - 新增实体形态用例(metadata dict、无 classification_result)与 ORM 形态用例对比; - 相关 5 个测试文件 64 passed;全量 unit 13913 passed。 ## staging 验收(容器内直调路由函数,真实 DB) 修复前:所有素材计算抛 AttributeError、四字段 None; 修复后待本 PR 部署复验。
xiaoxia added 1 commit 2026-08-30 08:03:07 +08:00
fix(segments): 余量计算兼容 Asset 领域实体(metadata dict)
CI/CD Pipeline / Check push changed paths (pull_request) Has been skipped
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 2m23s
CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 3m29s
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 3m29s
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 3m39s
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 1m45s
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 1m45s
CI/CD Pipeline / Validate - Code Quality (pull_request) Has been cancelled
CI/CD Pipeline / Unit Tests (pull_request) Has been cancelled
CI/CD Pipeline / Integration Tests (pull_request) Has been cancelled
CI/CD Pipeline / Build Production API Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Production Web Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been cancelled
CI/CD Pipeline / Deploy Production (pull_request) Has been cancelled
CI/CD Pipeline / Production Browser E2E (pull_request) Has been cancelled
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
CI/CD Pipeline / CI Gate (pull_request) Has been cancelled
AI Code Review / AI Code Review (pull_request) Has been cancelled
PR Automation / Auto Approve on CI Green (pull_request) Has been cancelled
Preview Deploy / Deploy Preview Environment (pull_request) Has been cancelled
0248c7e94e
staging 真实接口验收发现:路由 repository 返回的是 Asset 领域实体而非
ORM AssetModel,区间记录在 metadata dict(repository 与 classification_result
JSON 互转);_read_meta 只读 classification_result 列导致 AttributeError,
余量计算全部走异常兜底,四字段在真实接口里恒为 None。

_read_meta 双形态兼容:实体 metadata 为 dict 时直接用;否则读
classification_result JSON 字符串(ORM 形态)。
测试:补充实体形态/ORM 形态对比用例(13913 passed)。
auto-approve-bot added 1 commit 2026-08-30 08:07:49 +08:00
style: auto-format with black + isort + prettier [skip ci-format-check]
CI/CD Pipeline / Check push changed paths (pull_request) Has been skipped
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 2m42s
CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 3m18s
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 3m26s
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 3m46s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 3m55s
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 1m26s
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 1m4s
AI Code Review / AI Code Review (pull_request) Successful in 4m32s
CI/CD Pipeline / Unit Tests (pull_request) Successful in 3m18s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 6m9s
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 6m44s
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m30s
CI/CD Pipeline / CI Gate (pull_request) Successful in 24s
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 3m5s
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 5m1s
06f7ec34e3

🚀 预览环境已部署

项目 详情
PR号 #1550
预览链接 https://pr-1550.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据,请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后,预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1550 | | 预览链接 | [https://pr-1550.preview.xiaoxiajianji.com](https://pr-1550.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据,请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后,预览环境会自动清理。
Collaborator

代码审查结果 - PR #1550

⚠️ 问题(0个需要修改)

💡 建议(1个可选)

  1. apps/api/app/services/asset_segment_tracker.py 第72行:建议将 except Exception: 改为更具体的异常类型(如 json.JSONDecodeErrorTypeError),或者至少添加日志记录。虽然此处沿用旧逻辑是为了容错,但捕获所有异常可能会掩盖非预期的程序错误(如内存错误或键盘中断),不利于排查数据格式问题。

格式检查通过 | 逻辑审查通过 | 性能无明显问题


🤖 由 AI 代码审查机器人自动生成 | 2026-08-30 00:12:23 | 模型:

## 代码审查结果 - PR #1550 ### ⚠️ 问题(0个需要修改) 无 ### 💡 建议(1个可选) 1. **apps/api/app/services/asset_segment_tracker.py 第72行**:建议将 `except Exception:` 改为更具体的异常类型(如 `json.JSONDecodeError` 和 `TypeError`),或者至少添加日志记录。虽然此处沿用旧逻辑是为了容错,但捕获所有异常可能会掩盖非预期的程序错误(如内存错误或键盘中断),不利于排查数据格式问题。 --- ✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能无明显问题 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-08-30 00:12:23 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
auto-approve-bot approved these changes 2026-08-30 08:15:30 +08:00
auto-approve-bot left a comment
Collaborator

CI全绿,自动审批通过。

CI全绿,自动审批通过。
auto-approve-bot approved these changes 2026-08-30 08:15:30 +08:00
auto-approve-bot left a comment
Collaborator

CI全绿,自动审批通过。

CI全绿,自动审批通过。
auto-approve-bot merged commit 839426a2cc into develop 2026-08-30 08:21:01 +08:00
auto-approve-bot deleted branch fix/asset-availability-entity-meta 2026-08-30 08:21:01 +08:00

🗑️ 预览环境已清理

PR #1550 已关闭或合并,对应的预览环境已被清理。

如有需要,可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1550 已关闭或合并,对应的预览环境已被清理。 > 如有需要,可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.