xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 8 Pull Requests 8 Actions Packages Projects Releases 7 Wiki Activity

fix: 标题位置默认改为顶部(top) #1526

Open
xiaoxia wants to merge 11 commits from fix/title-position-default-top into develop
pull from: fix/title-position-default-top
merge into: xiaoxia:develop
Conversation 1 Commits 11 Files Changed 10
+1941 -1
xiaoxia commented 2026-08-28 14:43:52 +08:00
Owner
Copy Link
Copy Source

DEFAULT_TITLE_SETTINGS.position 从 bottom 改为 top

用户反馈标题位置默认应显示顶部而非底部

DEFAULT_TITLE_SETTINGS.position 从 bottom 改为 top 用户反馈标题位置默认应显示顶部而非底部
xiaoxia added 11 commits 2026-08-28 14:43:52 +08:00
test(unit): 新增 voice_presets/preset_bgm/edit_plan_clip 三个模块测试 0320bea6b5 
- voice_presets: 33 个测试，94% 覆盖率
- preset_bgm: 28 个测试，100% 覆盖率
- edit_plan_clip: 39 个测试，96% 覆盖率

共新增 100 个测试用例
test(unit): 新增 transition_presets/tts_job 两个模块测试 17494a1cde 
- transition_presets: 32 个测试，100% 覆盖率
- tts_job: 40 个测试，96% 覆盖率

共新增 72 个测试用例
test(unit): 新增 filter_presets/template_clip_config 两个模块测试 5ecc75c5ba 
- filter_presets: 31 个测试，含 build_ffmpeg_filter 强度插值逻辑
- template_clip_config: 28 个测试

本轮 Batch2 共 7 个模块，231 个测试用例
style: auto-format with black + isort + prettier [ci skip] cad16b3f87
test(unit): 新增 classification/generated_video 两个模块测试 0a447b4b68 
- classification: 12 个测试（枚举 + ClassificationJob 工厂方法）
- generated_video: 11 个测试（工厂方法 + 参数校验）
style: auto-format with black + isort + prettier [ci skip] de53975784
chore: trigger ci 98e74646f9
fix(test): 修复B017宽泛异常捕获 + StrEnum跨版本兼容问题
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 13s
Details
AI Code Review / AI Code Review (pull_request) Successful in 3m13s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 1m45s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 4m41s
Details
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Failing after 4m17s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 5m15s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 7m3s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 6m18s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m55s
Details
c5a949d502 
1. 将3个frozen测试的 pytest.raises(Exception) 改为 FrozenInstanceError
   （B017 assert-raises-exception 规则）
2. VoiceGender 测试 str() 断言改为 .value 比较
   （不同Python版本StrEnum的str()行为可能不同）
style: auto-format with black + isort + prettier [ci skip] 10897b3ee1
chore: trigger ci for #665
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 14m47s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Failing after 14m47s
Details
PR Automation / Auto Approve on CI Green (pull_request) Failing after 14m48s
Details
AI Code Review / AI Code Review (pull_request) Failing after 14m49s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 12s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 33s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m23s
Details
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 1m56s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m2s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 19s
Details
1af1d24d3c
fix: 标题位置默认改为顶部(top)
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 18s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m42s
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 3m1s
Details
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 4m47s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m21s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 9m20s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 10m1s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 9m42s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 10m7s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 10m9s
Details
b7987cf6c9 
DEFAULT_TITLE_SETTINGS.position 从 bottom 改为 top
auto-approve-bot commented 2026-08-28 14:46:31 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #1526

⚠️ 问题（0个需要修改）

无

💡 建议（2个可选）

  1. apps/web/src/pages/generate/GeneratePage.tsx 第109行：默认标题位置从 bottom 改为 top，这属于业务逻辑变更。建议确认前端 UI 布局是否适配顶部标题，避免遮挡视频画面关键区域或破坏原有视觉平衡。
  2. tests/unit/test_edit_plan_clip_domain.py 第236、264行：在单元测试中使用 time.sleep(0.001) 来验证时间戳更新。这会导致测试变慢且具有不确定性（取决于系统负载）。建议使用 unittest.mock 或 freezegun 等库来 mock 时间，确保测试的确定性和执行速度。

✅ 格式检查通过 | ✅ 逻辑审查通过 | ⚠️ 建议关注性能

🤖 由 AI 代码审查机器人自动生成 | 2026-08-28 06:46:31 | 模型:

## 代码审查结果 - PR #1526 ### ⚠️ 问题（0个需要修改） 无 ### 💡 建议（2个可选） 1. **apps/web/src/pages/generate/GeneratePage.tsx 第109行**：默认标题位置从 `bottom` 改为 `top`，这属于业务逻辑变更。建议确认前端 UI 布局是否适配顶部标题，避免遮挡视频画面关键区域或破坏原有视觉平衡。 2. **tests/unit/test_edit_plan_clip_domain.py 第236、264行**：在单元测试中使用 `time.sleep(0.001)` 来验证时间戳更新。这会导致测试变慢且具有不确定性（取决于系统负载）。建议使用 `unittest.mock` 或 `freezegun` 等库来 mock 时间，确保测试的确定性和执行速度。 --- ✅ 格式检查通过 | ✅ 逻辑审查通过 | ⚠️ 建议关注性能 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-08-28 06:46:31 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
Some checks are pending
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 18s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m42s
Required
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 3m1s
Details
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 4m47s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m21s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 9m20s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 10m1s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 9m42s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 10m7s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 10m9s
Details
CI/CD Pipeline / CI Gate (pull_request)
Required
This pull request has changes conflicting with the target branch.
  • apps/web/src/pages/generate/GeneratePage.tsx
  • tests/unit/test_classification_domain.py
  • tests/unit/test_generated_video_domain.py
  • tests/unit/test_tts_job_domain.py
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/title-position-default-top:fix/title-position-default-top
git checkout fix/title-position-default-top
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1526
Delete Branch "fix/title-position-default-top"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?