xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 8 Pull Requests 8 Actions Packages Projects Releases 7 Wiki Activity

fix: 标题换行计算使用原始font_size，与CSS预览一致 #1519

Merged
auto-approve-bot merged 1 commits from fix/title-wrap-fontsize-consistency into develop 2026-08-27 12:46:01 +08:00
Conversation 5 Commits 1 Files Changed 2
+45 -3
xiaoxia commented 2026-08-27 12:34:39 +08:00
Owner
Copy Link
Copy Source

问题

_wrap_title_text 函数在做字宽估算时使用了补偿后的ASS字号（_compensate_ass_fontsize(font_size)），导致换行位置与CSS预览不一致。

例如 font_size=113 时：

  • 当前代码用153px算字宽 → 每行6个字
  • CSS预览用113px → 每行8个字

修复

移除 _wrap_title_text 中对 _compensate_ass_fontsize 的调用，换行计算直接使用 font_size。1.35x补偿已在 build_ass_style 中用于ASS Fontsize渲染，不应重复影响换行计算。

改动

  • packages/domain/ass_subtitle_builder.py: 移除第228行 ass_font_size 赋值，第241行改用 font_size
  • tests/unit/domain/test_ass_subtitle_builder.py: 新增 TestWrapTitleTextFontSizeConsistency 测试类，3个测试用例

验证

  • 84个相关测试全部通过
  • font_size=113 + 标题"永康拾掇脚阔头" → 生成2行（与CSS预览一致），而非3行
## 问题 _wrap_title_text 函数在做字宽估算时使用了补偿后的ASS字号（_compensate_ass_fontsize(font_size)），导致换行位置与CSS预览不一致。 例如 font_size=113 时： - 当前代码用153px算字宽 → 每行6个字 - CSS预览用113px → 每行8个字 ## 修复 移除 _wrap_title_text 中对 _compensate_ass_fontsize 的调用，换行计算直接使用 font_size。1.35x补偿已在 build_ass_style 中用于ASS Fontsize渲染，不应重复影响换行计算。 ## 改动 - packages/domain/ass_subtitle_builder.py: 移除第228行 ass_font_size 赋值，第241行改用 font_size - tests/unit/domain/test_ass_subtitle_builder.py: 新增 TestWrapTitleTextFontSizeConsistency 测试类，3个测试用例 ## 验证 - 84个相关测试全部通过 - font_size=113 + 标题"永康拾掇脚阔头" → 生成2行（与CSS预览一致），而非3行
xiaoxia added 1 commit 2026-08-27 12:34:39 +08:00
fix: 标题换行计算使用原始font_size，与CSS预览一致
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 2m35s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 3m2s
Details
AI Code Review / AI Code Review (pull_request) Successful in 4m5s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 4m16s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 1m50s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 4m38s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 4m44s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m39s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 5m54s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 3m57s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 7m27s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m4s
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 26s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 3m0s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 4m0s
Details
8edc124b89 
- 移除 _wrap_title_text 中对 _compensate_ass_fontsize 的调用
- 换行计算直接使用 font_size，1.35x补偿仅用于ASS Fontsize渲染
- 修复 font_size=113 时每行字数从6个变为8个，与CSS预览一致
- 新增3个测试验证换行逻辑正确性

Fixes #任务C
auto-approve-bot commented 2026-08-27 12:38:43 +08:00
Collaborator
Copy Link
Copy Source

【阻塞级判定】

  • 是否存在阻塞级问题：否
  • 阻塞级问题数量：0 个

📊 审查概览

  • 整体评价：通过
  • 建议级问题数量：0 个

🔴 阻塞级问题（必须修复）

无

💡 改进建议（不阻塞合并）

无

✅ 良好实践

  1. [packages/domain/ass_subtitle_builder.py] 代码逻辑清晰，通过修改换行计算逻辑（从补偿后字体大小改为原始字体大小），有效解决了 ASS 渲染与 CSS 预览的换行不一致问题，注释对修改原因解释得非常清楚。
  2. [tests/unit/domain/test_ass_subtitle_builder.py] 针对修改的逻辑新增了完善的单元测试，覆盖了边界情况（刚好一行）、长文本换行以及中英文混合场景，确保了代码修改的正确性和健壮性。

🤖 由 AI 代码审查机器人自动生成 | 2026-08-27 04:38:43 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题：否 - 阻塞级问题数量：0 个 ### 📊 审查概览 - 整体评价：通过 - 建议级问题数量：0 个 ### 🔴 阻塞级问题（必须修复） 无 ### 💡 改进建议（不阻塞合并） 无 ### ✅ 良好实践 1. **[packages/domain/ass_subtitle_builder.py]** 代码逻辑清晰，通过修改换行计算逻辑（从补偿后字体大小改为原始字体大小），有效解决了 ASS 渲染与 CSS 预览的换行不一致问题，注释对修改原因解释得非常清楚。 2. **[tests/unit/domain/test_ass_subtitle_builder.py]** 针对修改的逻辑新增了完善的单元测试，覆盖了边界情况（刚好一行）、长文本换行以及中英文混合场景，确保了代码修改的正确性和健壮性。 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-08-27 04:38:43 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
gitea-actions bot commented 2026-08-27 12:39:24 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1519
预览链接 https://pr-1519.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1519 | | 预览链接 | [https://pr-1519.preview.xiaoxiajianji.com](https://pr-1519.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot approved these changes 2026-08-27 12:45:30 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-08-27 12:45:30 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot merged commit 24c862c741 into develop 2026-08-27 12:46:01 +08:00
auto-approve-bot deleted branch fix/title-wrap-fontsize-consistency 2026-08-27 12:46:01 +08:00
gitea-actions bot commented 2026-08-27 12:49:01 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1519 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1519 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1519
Delete Branch "fix/title-wrap-fontsize-consistency"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?