Compare commits

..

6 Commits

Author SHA1 Message Date
xiaoxia fcc12367f2 test: 补充 buildPayload smoke test import
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 1m25s
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 2m9s
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 2m10s
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m5s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m39s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m7s
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 5m23s
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m6s
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m12s
AI Code Review / AI Code Review (pull_request) Successful in 6m34s
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m50s
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
CI/CD Pipeline / CI Gate (pull_request) Successful in 23s
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 48s
CI/CD Pipeline / Production Browser E2E (pull_request) Failing after 1168h24m28s
CI/CD Pipeline / Deploy Production (pull_request) Failing after 1168h31m22s
CI/CD Pipeline / Build Production Worker Image (pull_request) Failing after 1168h36m51s
CI/CD Pipeline / Build Production API Image (pull_request) Failing after 1168h36m55s
CI/CD Pipeline / ACR Image Cleanup (pull_request) Failing after 1168h38m35s
CI/CD Pipeline / Staging API Integration Tests (pull_request) Failing after 1168h38m37s
CI/CD Pipeline / Staging E2E Tests (pull_request) Failing after 1168h38m39s
CI/CD Pipeline / Integration Tests (pull_request) Failing after 1168h38m41s
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Failing after 1168h42m54s
CI/CD Pipeline / Unit Tests (pull_request) Failing after 1168h44m3s
CI/CD Pipeline / PR Build Worker Image (pull_request) Failing after 1168h42m55s
CI/CD Pipeline / Build Staging Worker Image (pull_request) Failing after 1168h48m23s
CI/CD Pipeline / Build Staging API Image (pull_request) Failing after 1168h48m27s
CI/CD Pipeline / Build Production Web Image (pull_request) Failing after 1169h9m55s
CI/CD Pipeline / PR Build API Image (pull_request) Failing after 1169h16m10s
CI/CD Pipeline / Build Staging Web Image (pull_request) Failing after 1169h21m27s
2026-07-29 22:34:21 +08:00
xiaoxia 3fded204bb fix(lint): Prettier format useGenerateVideo
CI/CD Pipeline / Check if frontend-only change (pull_request) Has been cancelled
CI/CD Pipeline / Validate - Code Quality (pull_request) Has been cancelled
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Has been cancelled
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Has been cancelled
CI/CD Pipeline / Unit Tests (pull_request) Has been cancelled
CI/CD Pipeline / Integration Tests (pull_request) Has been cancelled
CI/CD Pipeline / Frontend Lint (pull_request) Has been cancelled
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been cancelled
CI/CD Pipeline / PR Build API Image (pull_request) Has been cancelled
CI/CD Pipeline / PR Build Web Image (pull_request) Has been cancelled
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Staging API Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been cancelled
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been cancelled
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been cancelled
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been cancelled
CI/CD Pipeline / Build Production API Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Production Web Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been cancelled
CI/CD Pipeline / Deploy Production (pull_request) Has been cancelled
CI/CD Pipeline / Production Browser E2E (pull_request) Has been cancelled
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been cancelled
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
CI/CD Pipeline / CI Gate (pull_request) Has been cancelled
AI Code Review / AI Code Review (pull_request) Has been cancelled
PR Automation / Auto Approve on CI Green (pull_request) Has been cancelled
PR Automation / Auto Merge on CI Green + Approved (pull_request) Has been cancelled
Preview Deploy / Deploy Preview Environment (pull_request) Has been cancelled
2026-07-29 22:33:45 +08:00
xiaoxia 9e6b8b01e3 fix(lint): Prettier format buildPayload 2026-07-29 22:33:44 +08:00
xiaoxia e091c5beb7 test(generate): 补充 buildPayload 模块 smoke test
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 29s
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m6s
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m4s
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 40s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m7s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m40s
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m30s
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 47s
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 59s
AI Code Review / AI Code Review (pull_request) Successful in 6m14s
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m40s
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
CI/CD Pipeline / CI Gate (pull_request) Failing after 9s
CI/CD Pipeline / Production Browser E2E (pull_request) Failing after 1169h9m1s
CI/CD Pipeline / Deploy Production (pull_request) Failing after 1169h9m24s
CI/CD Pipeline / Build Production Worker Image (pull_request) Failing after 1169h12m24s
CI/CD Pipeline / Build Production API Image (pull_request) Failing after 1169h12m25s
CI/CD Pipeline / ACR Image Cleanup (pull_request) Failing after 1169h12m27s
CI/CD Pipeline / Staging API Integration Tests (pull_request) Failing after 1169h12m27s
CI/CD Pipeline / Staging E2E Tests (pull_request) Failing after 1169h12m28s
CI/CD Pipeline / Integration Tests (pull_request) Failing after 1169h12m32s
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Failing after 1169h17m29s
CI/CD Pipeline / PR Build API Image (pull_request) Failing after 1169h17m50s
CI/CD Pipeline / Unit Tests (pull_request) Failing after 1169h18m15s
CI/CD Pipeline / Build Staging Worker Image (pull_request) Failing after 1169h22m43s
CI/CD Pipeline / Build Staging API Image (pull_request) Failing after 1169h22m47s
CI/CD Pipeline / Build Production Web Image (pull_request) Failing after 1169h45m26s
CI/CD Pipeline / PR Build Worker Image (pull_request) Failing after 1169h50m33s
CI/CD Pipeline / Build Staging Web Image (pull_request) Failing after 1169h55m47s
2026-07-29 22:00:17 +08:00
xiaoxia aef01b5091 refactor(generate): 简化 useGenerateVideo,抽取payload构建和校验 2026-07-29 21:59:53 +08:00
xiaoxia ee704efc0b refactor(generate): 提取 buildPayload 和 validateGenerateInputs 2026-07-29 21:59:30 +08:00
4 changed files with 85 additions and 367 deletions
@@ -0,0 +1,76 @@
import type { UseGenerateVideoProps } from "./types"
import { buildVoiceConfig } from "./voiceConfig"
/**
* 构建 updateEditPlan 的 payload
* 从 props 中提取需要的字段,组装成 API 所需的 config 结构
*/
export const buildEditPlanPayload = (props: UseGenerateVideoProps) => {
const {
titleSettings,
selectedMaterials,
materialMode,
smartSelectedIds,
voiceMode,
selectedVoice,
selectedClonedVoice,
coverSettings,
videoRatio,
style,
duration,
autoSubtitles,
bgm,
generateCount,
} = props
const voiceConfig = buildVoiceConfig({
voiceMode,
selectedVoice,
selectedClonedVoice,
})
return {
name: titleSettings.title.trim(),
config: {
asset_ids: materialMode === "auto" ? smartSelectedIds : selectedMaterials,
title_config: {
ai_auto_select: titleSettings.aiAutoSelect,
content: titleSettings.title,
position: titleSettings.position,
font_preset: titleSettings.font,
font_color: titleSettings.color,
font_size: titleSettings.size,
},
cover_config: coverSettings,
...voiceConfig,
ratio: videoRatio,
style,
duration,
auto_subtitles: autoSubtitles,
bgm,
generate_count: generateCount,
material_mode: materialMode,
},
total_duration: duration,
status: "editing" as const,
}
}
/**
* 生成前置校验
* 返回错误信息,通过则返回 null
*/
export const validateGenerateInputs = (props: UseGenerateVideoProps): string | null => {
const { titleSettings, materialMode, selectedMaterials, voiceMode, selectedClonedVoice } = props
if (!titleSettings.title.trim()) {
return "请先选择或输入标题"
}
if (materialMode === "manual" && selectedMaterials.length === 0) {
return "请至少选择一个素材"
}
if (voiceMode === "clone" && !selectedClonedVoice) {
return "请先选择一个克隆音色"
}
return null
}
@@ -9,27 +9,11 @@ import { generateEditPlan, updateEditPlan, getEditPlan } from "@/api/template-ed
import type { UseGenerateVideoProps } from "./generate-video/types"
import { getGenerationPhase } from "./generate-video/phase"
import { useGenerationPolling } from "./generate-video/useGenerationPolling"
import { buildVoiceConfig } from "./generate-video/voiceConfig"
import { buildEditPlanPayload, validateGenerateInputs } from "./generate-video/buildPayload"
import { extractBackendError, translateError } from "./generate-video/errorUtils"
export function useGenerateVideo(props: UseGenerateVideoProps) {
const {
titleSettings,
selectedTemplate,
selectedMaterials,
materialMode,
smartSelectedIds,
voiceMode,
selectedVoice,
selectedClonedVoice,
coverSettings,
videoRatio,
style,
duration,
autoSubtitles,
bgm,
generateCount,
} = props
const { selectedTemplate } = props
/* ── 生成状态 ── */
const [generating, setGenerating] = useState(false)
@@ -58,16 +42,9 @@ export function useGenerateVideo(props: UseGenerateVideoProps) {
/* ── 生成视频 ── */
const generate = useCallback(async () => {
if (!titleSettings.title.trim()) {
message.warning("请先选择或输入标题")
return
}
if (materialMode === "manual" && selectedMaterials.length === 0) {
message.warning("请至少选择一个素材")
return
}
if (voiceMode === "clone" && !selectedClonedVoice) {
message.warning("请先选择一个克隆音色")
const errorMsg = validateGenerateInputs(props)
if (errorMsg) {
message.warning(errorMsg)
return
}
@@ -78,41 +55,13 @@ export function useGenerateVideo(props: UseGenerateVideoProps) {
clearTimer()
try {
const voiceConfig = buildVoiceConfig({
voiceMode,
selectedVoice,
selectedClonedVoice,
})
const payload = buildEditPlanPayload(props)
// 获取或创建草稿
await getEditPlan(selectedTemplate)
// 更新草稿内容 + 切换到 editing 状态
await updateEditPlan(selectedTemplate, {
name: titleSettings.title.trim(),
config: {
asset_ids: materialMode === "auto" ? smartSelectedIds : selectedMaterials,
title_config: {
ai_auto_select: titleSettings.aiAutoSelect,
content: titleSettings.title,
position: titleSettings.position,
font_preset: titleSettings.font,
font_color: titleSettings.color,
font_size: titleSettings.size,
},
cover_config: coverSettings,
...voiceConfig,
ratio: videoRatio,
style,
duration,
auto_subtitles: autoSubtitles,
bgm,
generate_count: generateCount,
material_mode: materialMode,
},
total_duration: duration,
status: "editing",
})
await updateEditPlan(selectedTemplate, payload)
await generateEditPlan(selectedTemplate)
startPolling()
@@ -125,25 +74,7 @@ export function useGenerateVideo(props: UseGenerateVideoProps) {
setGenerateError(finalMsg)
message.error(finalMsg)
}
}, [
titleSettings,
selectedMaterials,
selectedVoice,
voiceMode,
selectedClonedVoice,
videoRatio,
style,
duration,
autoSubtitles,
bgm,
selectedTemplate,
generateCount,
materialMode,
coverSettings,
smartSelectedIds,
clearTimer,
startPolling,
])
}, [props, selectedTemplate, clearTimer, startPolling])
/* 重新生成(失败后重试) */
const retry = useCallback(() => {
@@ -42,3 +42,4 @@ import "@/pages/generate/hooks/generate-video/types"
import "@/pages/generate/hooks/generate-video/phase"
import "@/pages/generate/hooks/generate-video/voiceConfig"
import "@/pages/generate/hooks/generate-video/errorUtils"
import "@/pages/generate/hooks/generate-video/buildPayload"
-290
View File
@@ -1,290 +0,0 @@
"""media_validation 媒体文件校验单测."""
import pytest
from domain.media_validation import (
MIN_AUDIO_FILE_SIZE,
MIN_IMAGE_FILE_SIZE,
MIN_VIDEO_FILE_SIZE,
SUPPORTED_VIDEO_CODECS,
is_valid_media,
safe_parse_fps,
)
# ── 常量测试 ─────────────────────────────────────────────────────────────────
class TestConstants:
"""模块常量"""
def test_min_sizes(self):
assert MIN_VIDEO_FILE_SIZE == 1024
assert MIN_AUDIO_FILE_SIZE == 100
assert MIN_IMAGE_FILE_SIZE == 100
def test_supported_codecs_is_frozenset(self):
assert isinstance(SUPPORTED_VIDEO_CODECS, frozenset)
def test_supported_codecs_includes_common(self):
assert "h264" in SUPPORTED_VIDEO_CODECS
assert "hevc" in SUPPORTED_VIDEO_CODECS
assert "vp9" in SUPPORTED_VIDEO_CODECS
assert "av1" in SUPPORTED_VIDEO_CODECS
assert "mpeg4" in SUPPORTED_VIDEO_CODECS
assert "prores" in SUPPORTED_VIDEO_CODECS
def test_supported_codecs_count(self):
assert len(SUPPORTED_VIDEO_CODECS) >= 20
# ── safe_parse_fps ───────────────────────────────────────────────────────────
class TestSafeParseFps:
"""safe_parse_fps 函数"""
def test_simple_decimal(self):
assert safe_parse_fps("30.0") == 30.0
def test_integer_string(self):
assert safe_parse_fps("24") == 24.0
def test_fraction_format(self):
assert abs(safe_parse_fps("30000/1001") - 29.97) < 0.01
def test_simple_fraction(self):
assert safe_parse_fps("30/1") == 30.0
def test_24fps_fraction(self):
assert safe_parse_fps("24/1") == 24.0
def test_60fps_fraction(self):
assert safe_parse_fps("60000/1001") == pytest.approx(59.94, abs=0.01)
def test_zero_denominator_returns_zero(self):
assert safe_parse_fps("30/0") == 0.0
def test_empty_string_returns_zero(self):
assert safe_parse_fps("") == 0.0
def test_invalid_string_returns_zero(self):
assert safe_parse_fps("invalid") == 0.0
def test_none_numerator_fraction(self):
assert safe_parse_fps("abc/1001") == 0.0
def test_negative_fps(self):
assert safe_parse_fps("-30") == -30.0
def test_very_high_fps(self):
assert safe_parse_fps("240/1") == 240.0
def test_multiple_slashes(self):
# 只按第一个 / 分割
# "30/1/2" → num="30", den="1/2" → float("1/2") 抛异常 → 返回 0
assert safe_parse_fps("30/1/2") == 0.0
def test_float_fraction(self):
result = safe_parse_fps("29.97/1")
assert result == pytest.approx(29.97)
def test_zero_fps(self):
assert safe_parse_fps("0") == 0.0
def test_zero_numerator(self):
assert safe_parse_fps("0/1000") == 0.0
# ── is_valid_media - video ───────────────────────────────────────────────────
class TestIsValidMediaVideo:
"""is_valid_media 视频校验"""
def test_valid_video(self):
metadata = {
"size_bytes": 1024 * 1024, # 1MB
"duration": 10.0,
"codec": "h264",
"width": 1920,
"height": 1080,
}
assert is_valid_media(metadata, "video") is True
def test_small_file_invalid(self):
metadata = {"size_bytes": 100, "duration": 10.0}
assert is_valid_media(metadata, "video") is False
def test_exact_min_size_valid(self):
metadata = {"size_bytes": MIN_VIDEO_FILE_SIZE, "duration": 1.0}
assert is_valid_media(metadata, "video") is True
def test_zero_duration_invalid(self):
metadata = {"size_bytes": 1024 * 1024, "duration": 0}
assert is_valid_media(metadata, "video") is False
def test_negative_duration_invalid(self):
metadata = {"size_bytes": 1024 * 1024, "duration": -1.0}
assert is_valid_media(metadata, "video") is False
def test_unsupported_codec_still_valid(self):
# 非白名单编码仍允许通过(不做严格拦截)
metadata = {
"size_bytes": 1024 * 1024,
"duration": 10.0,
"codec": "unknown_codec_xyz",
}
assert is_valid_media(metadata, "video") is True
def test_empty_codec_valid(self):
metadata = {"size_bytes": 1024 * 1024, "duration": 10.0, "codec": ""}
assert is_valid_media(metadata, "video") is True
def test_no_codec_valid(self):
metadata = {"size_bytes": 1024 * 1024, "duration": 10.0}
assert is_valid_media(metadata, "video") is True
def test_hevc_codec_valid(self):
metadata = {
"size_bytes": 1024 * 1024,
"duration": 10.0,
"codec": "hevc",
}
assert is_valid_media(metadata, "video") is True
def test_codec_case_insensitive(self):
metadata = {
"size_bytes": 1024 * 1024,
"duration": 10.0,
"codec": "H264",
}
assert is_valid_media(metadata, "video") is True
def test_missing_size_invalid(self):
metadata = {"duration": 10.0}
assert is_valid_media(metadata, "video") is False
def test_missing_duration_invalid(self):
metadata = {"size_bytes": 1024 * 1024}
assert is_valid_media(metadata, "video") is False
def test_empty_metadata_invalid(self):
assert is_valid_media({}, "video") is False
# ── is_valid_media - audio ───────────────────────────────────────────────────
class TestIsValidMediaAudio:
"""is_valid_media 音频校验"""
def test_valid_audio(self):
metadata = {"size_bytes": 1024, "duration": 30.0, "codec": "aac"}
assert is_valid_media(metadata, "audio") is True
def test_small_audio_invalid(self):
metadata = {"size_bytes": 50, "duration": 30.0}
assert is_valid_media(metadata, "audio") is False
def test_exact_min_size_valid(self):
metadata = {"size_bytes": MIN_AUDIO_FILE_SIZE, "duration": 1.0}
assert is_valid_media(metadata, "audio") is True
def test_zero_duration_invalid(self):
metadata = {"size_bytes": 1024, "duration": 0}
assert is_valid_media(metadata, "audio") is False
def test_negative_duration_invalid(self):
metadata = {"size_bytes": 1024, "duration": -5.0}
assert is_valid_media(metadata, "audio") is False
def test_empty_metadata_invalid(self):
assert is_valid_media({}, "audio") is False
def test_very_short_audio_valid(self):
metadata = {"size_bytes": 200, "duration": 0.5}
assert is_valid_media(metadata, "audio") is True
# ── is_valid_media - image ───────────────────────────────────────────────────
class TestIsValidMediaImage:
"""is_valid_media 图片校验"""
def test_valid_image(self):
metadata = {"size_bytes": 1024, "width": 1920, "height": 1080}
assert is_valid_media(metadata, "image") is True
def test_small_image_invalid(self):
metadata = {"size_bytes": 50, "width": 1920, "height": 1080}
assert is_valid_media(metadata, "image") is False
def test_exact_min_size_valid(self):
metadata = {
"size_bytes": MIN_IMAGE_FILE_SIZE,
"width": 100,
"height": 100,
}
assert is_valid_media(metadata, "image") is True
def test_zero_width_invalid(self):
metadata = {"size_bytes": 1024, "width": 0, "height": 1080}
assert is_valid_media(metadata, "image") is False
def test_zero_height_invalid(self):
metadata = {"size_bytes": 1024, "width": 1920, "height": 0}
assert is_valid_media(metadata, "image") is False
def test_negative_width_invalid(self):
metadata = {"size_bytes": 1024, "width": -1, "height": 1080}
assert is_valid_media(metadata, "image") is False
def test_small_image_valid(self):
metadata = {"size_bytes": 200, "width": 10, "height": 10}
assert is_valid_media(metadata, "image") is True
def test_missing_width_invalid(self):
metadata = {"size_bytes": 1024, "height": 1080}
assert is_valid_media(metadata, "image") is False
def test_missing_height_invalid(self):
metadata = {"size_bytes": 1024, "width": 1920}
assert is_valid_media(metadata, "image") is False
def test_empty_metadata_invalid(self):
assert is_valid_media({}, "image") is False
# ── is_valid_media - edge cases ─────────────────────────────────────────────
class TestIsValidMediaEdgeCases:
"""is_valid_media 边界情况"""
def test_invalid_media_type(self):
metadata = {"size_bytes": 1024, "duration": 10.0}
assert is_valid_media(metadata, "document") is False
def test_empty_media_type(self):
metadata = {"size_bytes": 1024}
assert is_valid_media(metadata, "") is False
def test_string_size_converted(self):
metadata = {"size_bytes": "2048", "duration": "5.0"}
assert is_valid_media(metadata, "video") is True
def test_video_size_as_string(self):
metadata = {"size_bytes": "1000000", "duration": "30"}
assert is_valid_media(metadata, "video") is True
def test_invalid_size_string_raises(self):
# int("abc") 会抛 ValueError
metadata = {"size_bytes": "abc", "duration": 10.0}
with pytest.raises(ValueError):
is_valid_media(metadata, "video")
def test_none_size_raises(self):
# int(None) 会抛 TypeError
metadata = {"size_bytes": None, "duration": 10.0}
with pytest.raises(TypeError):
is_valid_media(metadata, "video")